Re-land torchrec pipeline refactor (with fix) #2853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71086956 |
che-sh
added a commit
to che-sh/torchrec
that referenced
this pull request
Mar 28, 2025
Summary: Reintroduces pytorch#2741 with fix **Note**: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing Reviewed By: sarckk Differential Revision: D71086956
che-sh
force-pushed
the
export-D71086956
branch
from
7ac60df to
82201f6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71086956 |
che-sh
force-pushed
the
export-D71086956
branch
from
82201f6 to
a382906
Compare
che-sh
added a commit
to che-sh/torchrec
that referenced
this pull request
Apr 16, 2025
Summary: Reintroduces pytorch#2741 with fix **Note**: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing Reviewed By: sarckk Differential Revision: D71086956
|
This pull request was exported from Phabricator. Differential Revision: D71086956 |
che-sh
added a commit
to che-sh/torchrec
that referenced
this pull request
Apr 16, 2025
Summary: Pull Request resolved: pytorch#2853 Reintroduces pytorch#2741 with fix **Note**: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing Reviewed By: sarckk Differential Revision: D71086956
che-sh
force-pushed
the
export-D71086956
branch
from
a382906 to
132b222
Compare
che-sh
added a commit
to che-sh/torchrec
that referenced
this pull request
May 8, 2025
Summary: Reintroduces pytorch#2741 with fix **Note**: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing Reviewed By: sarckk, TroyGarden Differential Revision: D71086956
che-sh
added a commit
to che-sh/torchrec
that referenced
this pull request
May 8, 2025
Summary: Reintroduces pytorch#2741 with fix **Note**: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing Reviewed By: sarckk, TroyGarden Differential Revision: D71086956
|
This pull request was exported from Phabricator. Differential Revision: D71086956 |
che-sh
added a commit
to che-sh/torchrec
that referenced
this pull request
May 8, 2025
Summary: Pull Request resolved: pytorch#2853 Reintroduces pytorch#2741 with fix **Note**: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing Reviewed By: sarckk, TroyGarden Differential Revision: D71086956
che-sh
added a commit
to che-sh/torchrec
that referenced
this pull request
May 8, 2025
Summary: Reintroduces pytorch#2741 with fix **Note**: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing Reviewed By: sarckk, TroyGarden Differential Revision: D71086956
|
This pull request was exported from Phabricator. Differential Revision: D71086956 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D71086956 |
che-sh
added a commit
to che-sh/torchrec
that referenced
this pull request
May 8, 2025
Summary: Pull Request resolved: pytorch#2853 Reintroduces pytorch#2741 with fix **Note**: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing Reviewed By: sarckk, TroyGarden Differential Revision: D71086956
che-sh
added a commit
to che-sh/torchrec
that referenced
this pull request
May 8, 2025
Summary: Reintroduces pytorch#2741 with fix **Note**: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing Reviewed By: sarckk, TroyGarden Differential Revision: D71086956
|
This pull request was exported from Phabricator. Differential Revision: D71086956 |
che-sh
added a commit
to che-sh/torchrec
that referenced
this pull request
May 8, 2025
Summary: Reintroduces pytorch#2741 with fix **Note**: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing Reviewed By: sarckk, TroyGarden Differential Revision: D71086956
Summary: Pull Request resolved: pytorch#2853 Reintroduces pytorch#2741 with fix **Note**: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing Reviewed By: sarckk, TroyGarden Differential Revision: D71086956
|
This pull request was exported from Phabricator. Differential Revision: D71086956 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reintroduces #2741 with fix
Note: restores original for now, to make it easier to review the fix (next diff). Will merge the next diff (with the fix) into this before landing
Reviewed By: sarckk
Differential Revision: D71086956